[webkit-reviews] review granted: [Bug 176069] [WinCairo] Add Network Process files for wincairo webkit : [Attachment 319655] Add basic versions/stubs for Network Process files for wincairo webkit

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted  review:
Bug 176069: [WinCairo] Add Network Process files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=176069

Attachment 319655: Add basic versions/stubs for Network Process files for
wincairo webkit

https://bugs.webkit.org/attachment.cgi?id=319655&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319655
  --> https://bugs.webkit.org/attachment.cgi?id=319655
Add basic versions/stubs for Network Process files for wincairo webkit

View in context: https://bugs.webkit.org/attachment.cgi?id=319655&action=review

> Source/WebKit/NetworkProcess/Downloads/curl/DownloadCurl.cpp:29
> +#if !USE(NETWORK_SESSION)

We should be planning to make a NETWORK_SESSION implementation for CURL soon. 
Mac, iOS, and GTK have already switched.  The only reason we have this code in
WebKit is because of El Capitan.
Luckily a NetworkSession implementation is quite similar to a ResourceHandle
implementation using asynchronous client callbacks.