[webkit-reviews] review granted: [Bug 176215] Letter-spacing should disable ligatures : [Attachment 319643] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 176215: Letter-spacing should disable ligatures
https://bugs.webkit.org/show_bug.cgi?id=176215

Attachment 319643: Patch

https://bugs.webkit.org/attachment.cgi?id=319643&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 319643
  --> https://bugs.webkit.org/attachment.cgi?id=319643
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319643&action=review

> Source/WebCore/ChangeLog:3
> +	   No letter spacing between f & l for audiowide font (not happening in
firefox)

Can this adopt the title from the bug, which is much better?

> Source/WebCore/platform/graphics/FontDescription.h:142
> +	   setVariantDiscretionaryLigatures(FontVariantLigatures::No);
> +	   setVariantHistoricalLigatures(FontVariantLigatures::No);

Technically no test for these two?