[webkit-reviews] review granted: [Bug 176231] Move ServiceWorkerJob from FetchLoader to ThreadableLoader : [Attachment 319632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 1 13:15:03 PDT 2017


youenn fablet <youennf at gmail.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 176231: Move ServiceWorkerJob from FetchLoader to ThreadableLoader
https://bugs.webkit.org/show_bug.cgi?id=176231

Attachment 319632: Patch

https://bugs.webkit.org/attachment.cgi?id=319632&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 319632
  --> https://bugs.webkit.org/attachment.cgi?id=319632
Patch

r=me.
There is no need to create a FetchRequest object here so this is better like
this for now.

Since FetchLoader.h/FetchLoaderClient.h are no longer used in WebKit2, they
could be reverted to not being "Private" headers.

View in context: https://bugs.webkit.org/attachment.cgi?id=319632&action=review

> Source/WebCore/loader/ThreadableLoader.h:46
> +enum PreflightPolicy {

Would be nice as enum class, but hey...


More information about the webkit-reviews mailing list