[webkit-reviews] review denied: [Bug 175890] Image data should be coalesced if it comes in small chunks before updating the ImageSource : [Attachment 319013] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 175890: Image data should be coalesced if it comes in small chunks before
updating the ImageSource
https://bugs.webkit.org/show_bug.cgi?id=175890

Attachment 319013: Patch

https://bugs.webkit.org/attachment.cgi?id=319013&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 319013
  --> https://bugs.webkit.org/attachment.cgi?id=319013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319013&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:449
> +    static const auto coalesceDataDurations =
makeNeverDestroyed(Vector<double> { 0, 1, 3, 6, 15 });

Vector<Seconds>.

makeNeverDestroyed is overkill, but I guess you might need it if static
Seconds[] doesn't work.

> Source/WebCore/loader/cache/CachedImage.cpp:456
> +    m_coalesceDataTime = time;

A function called shouldCoalesceDataBuffer() should not change state, I think.
m_coalesceDataTime should be changed when you actually do the coalescing.

> Source/WebCore/loader/cache/CachedImage.h:163
> +    size_t m_currentCoalesceDataDuration { 0 };

This isn't a duration, right? So the name is misleading. It's an index into
some array.