[webkit-reviews] review denied: [Bug 176069] [WinCairo] Add Network Process files for wincairo webkit : [Attachment 319612] Add basic versions/stubs for Network Process files for wincairo webkit (no LegacyCustomProtocolManager)

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 176069: [WinCairo] Add Network Process files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=176069

Attachment 319612: Add basic versions/stubs for Network Process files for
wincairo webkit (no LegacyCustomProtocolManager)

https://bugs.webkit.org/attachment.cgi?id=319612&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319612
  --> https://bugs.webkit.org/attachment.cgi?id=319612
Add basic versions/stubs for Network Process files for wincairo webkit (no
LegacyCustomProtocolManager)

View in context: https://bugs.webkit.org/attachment.cgi?id=319612&action=review

> Source/WebKit/NetworkProcess/win/SystemProxyWin.cpp:70
> +	   goto exitGracefully;
> +
> +    wcstombs(buffer, tHost, bufferLen);
> +    result = true;
> +
> +exitGracefully:
> +    if (tRegBuffer)
> +	   delete [] tRegBuffer;

This is what std::unique_ptr<TCHAR[]> is for.  Let's not add goto for this.