[webkit-reviews] review requested: [Bug 176644] WebAssembly: Wasm::IndexOrName has a raw pointer to Name : [Attachment 325543] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 31 22:00:45 PDT 2017
JF Bastien <jfbastien at apple.com> has asked for review:
Bug 176644: WebAssembly: Wasm::IndexOrName has a raw pointer to Name
https://bugs.webkit.org/show_bug.cgi?id=176644
Attachment 325543: patch
https://bugs.webkit.org/attachment.cgi?id=325543&action=review
--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
Created attachment 325543
--> https://bugs.webkit.org/attachment.cgi?id=325543&action=review
patch
Odd, looks like my compiler does return value optimization to move, but the
bots do it to copy, and Ref hates that. Using RefPtr instead, since that's what
I store to right after anyways.
More information about the webkit-reviews
mailing list