[webkit-reviews] review denied: [Bug 77568] [Cocoa] Glyph lookup should be language-sensitive (specifically between Yiddish and Hebrew) : [Attachment 325541] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has denied  review:
Bug 77568: [Cocoa] Glyph lookup should be language-sensitive (specifically
between Yiddish and Hebrew)
https://bugs.webkit.org/show_bug.cgi?id=77568

Attachment 325541: Patch

https://bugs.webkit.org/attachment.cgi?id=325541&action=review




--- Comment #34 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 325541
  --> https://bugs.webkit.org/attachment.cgi?id=325541
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325541&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:333
> +	   simpleIterator.finalize(nullptr);

All the calls to finalize() are probably not correct, because we should only
finalize when we are iterating to the very end of the TextRun.