[webkit-reviews] review granted: [Bug 179040] Web Inspector: Styles Redesign: Hovering over a selector should highlight matching elements on the page : [Attachment 325511] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 179040: Web Inspector: Styles Redesign: Hovering over a selector should
highlight matching elements on the page
https://bugs.webkit.org/show_bug.cgi?id=179040

Attachment 325511: Patch

https://bugs.webkit.org/attachment.cgi?id=325511&action=review




--- Comment #4 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 325511
  --> https://bugs.webkit.org/attachment.cgi?id=325511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325511&action=review

> Source/WebInspectorUI/ChangeLog:13
> +	   Use mouseenter/mouseleave events instead of mousein/mouseout (as in
the old styles sidebar)
> +	   to avoid unnecessary events being fired:
> +	     - mouseenter/mouseleave fires once when the mouse cursor
enters/leaves the element.
> +	     - mousein/mouseout fires every time the mouse cursor enters/leaves
the element and any of its children.

I don't think this explanation is necessary, especially since you aren't
modifying the old sidebar.  Feel free to keep it if you think it adds something
though :)