[webkit-reviews] review granted: [Bug 179096] transferFromImageBitmap should update canvas dimensions : [Attachment 325530] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 31 19:06:02 PDT 2017


Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 179096: transferFromImageBitmap should update canvas dimensions
https://bugs.webkit.org/show_bug.cgi?id=179096

Attachment 325530: Patch

https://bugs.webkit.org/attachment.cgi?id=325530&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 325530
  --> https://bugs.webkit.org/attachment.cgi?id=325530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325530&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:982
>	   m_imageBuffer = WTFMove(buffer);
>      }
>  
> +    if (m_imageBuffer && m_size != m_imageBuffer->internalSize())
> +	   m_size = m_imageBuffer->internalSize();

Why is this function const?


More information about the webkit-reviews mailing list