[webkit-reviews] review granted: [Bug 65218] Web Inspector: Add Inspector menu items to Mac MiniBrowser : [Attachment 325490] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 65218: Web Inspector: Add Inspector menu items to Mac MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=65218

Attachment 325490: Patch

https://bugs.webkit.org/attachment.cgi?id=325490&action=review




--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 325490
  --> https://bugs.webkit.org/attachment.cgi?id=325490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325490&action=review

r=me, but it should be easy to implement the WebKit1 portion, so I'd strongly
suggest adding that before landing.

> Tools/MiniBrowser/mac/BrowserWindowController.h:73
>  - (IBAction)dumpSourceToConsole:(id)sender;

Does anyone actually implement this? It doesn't seem to do anything, unless I'm
missing it. We should remove this in a follow-up patch.

> Tools/MiniBrowser/mac/WK1BrowserWindowController.m:257
> +- (IBAction)showHideWebInspector:(id)sender
> +{
> +}

Hmm, I think you can do:

    WebInspector *inspector = _webView.inspector;
    if (inspector.isOpen)
	[inspector close:sender];
    else
	[inspector show:sender];

As long as you import:

    <WebKit/WebViewPrivate.h>
    <WebKit/WebInspector.h>

You probably then need to fix up -validateMenuItem for this.