[webkit-reviews] review granted: [Bug 179066] [Web Animations] Support AnimationEffect parameter in Animation constructor and read-write timeline property : [Attachment 325467] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 179066: [Web Animations] Support AnimationEffect parameter in Animation
constructor and read-write timeline property
https://bugs.webkit.org/show_bug.cgi?id=179066

Attachment 325467: Patch

https://bugs.webkit.org/attachment.cgi?id=325467&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 325467
  --> https://bugs.webkit.org/attachment.cgi?id=325467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325467&action=review

> Source/WebCore/animation/WebAnimation.cpp:67
> +void WebAnimation::setTimeline(RefPtr<AnimationTimeline>&& timeline)

I'm not sure you need && here. Why do you use it?

The calling location is always casting a raw pointer to a RefPtr.  I guess the
implicitly created RefPtr can be moved, but I'm not sure it makes much
difference. I'm clearly not a C++ expert.