[webkit-reviews] review granted: [Bug 178924] Implement WKFullscreenWindowController for iOS. : [Attachment 325420] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 178924: Implement WKFullscreenWindowController for iOS.
https://bugs.webkit.org/show_bug.cgi?id=178924

Attachment 325420: Patch

https://bugs.webkit.org/attachment.cgi?id=325420&action=review




--- Comment #22 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 325420
  --> https://bugs.webkit.org/attachment.cgi?id=325420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325420&action=review

> Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.h:54
> +- (void)beganEnterFullScreenWithInitialFrame:(const
WebCore::IntRect&)initialFrame finalFrame:(const WebCore::IntRect&)finalFrame;
> +- (void)beganExitFullScreenWithInitialFrame:(const
WebCore::IntRect&)initialFrame finalFrame:(const WebCore::IntRect&)finalFrame;

CGRects?

> Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.mm:120
> +- (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event
> +{
> +    [[self target] performSelector:[self action]];
> +    return nil;
> +}

I think it's too fragile to use this. UIKIt could change at any time and add a
new call to this which would break fullscreen. You really need to figure out if
it's an actual user gesture.

> Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.mm:188
> +    [backLayerTintView release];

Nope.

> Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.mm:195
> +    [topLayerTintView release];

Nope.

> Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.mm:204
> +    [self setView:[[[UIView alloc] initWithFrame:[[UIScreen mainScreen]
bounds]] autorelease]];

We prefer to avoid autorelease, and use RetainPtr<>