[webkit-reviews] review granted: [Bug 179056] [Payment Request] show() should only be called with user activation : [Attachment 325439] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Andy Estes <aestes at apple.com>'s request
for review:
Bug 179056: [Payment Request] show() should only be called with user activation
https://bugs.webkit.org/show_bug.cgi?id=179056

Attachment 325439: Patch

https://bugs.webkit.org/attachment.cgi?id=325439&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 325439
  --> https://bugs.webkit.org/attachment.cgi?id=325439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325439&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:385
> +    if (!ScriptController::processingUserGesture()) {

Can this use UserGestureIndicator::processingUserGesture() instead?  I'm not
sure why we have the ScriptController wrapper.