[webkit-reviews] review denied: [Bug 179020] [Touch Bar Web API] Add support for menuitem tag : [Attachment 325391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 30 19:01:20 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has denied Aishwarya Nirmal
<anirmal at apple.com>'s request for review:
Bug 179020: [Touch Bar Web API] Add support for menuitem tag
https://bugs.webkit.org/show_bug.cgi?id=179020

Attachment 325391: Patch

https://bugs.webkit.org/attachment.cgi?id=325391&action=review




--- Comment #30 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 325391
  --> https://bugs.webkit.org/attachment.cgi?id=325391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325391&action=review

> Source/WebCore/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

You need to describe what kind of API you're implementing and what code changes
you're making for it.
r- due to the lack of change log descriptions and the test failures.

> Source/WebCore/ChangeLog:8
> +	   * CMakeLists.txt:

Given the feature has been removed from the HTML specification, we should put
this under a runtime flag.


More information about the webkit-reviews mailing list