[webkit-reviews] review granted: [Bug 178807] Web Inspector: Canvas Tab: no path components shown in recording content view after selecting a recording via View Recordings... dropdown : [Attachment 325133] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 30 13:27:12 PDT 2017


Brian Burg <bburg at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178807: Web Inspector: Canvas Tab: no path components shown in recording
content view after selecting a recording via View Recordings... dropdown
https://bugs.webkit.org/show_bug.cgi?id=178807

Attachment 325133: Patch

https://bugs.webkit.org/attachment.cgi?id=325133&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 325133
  --> https://bugs.webkit.org/attachment.cgi?id=325133
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325133&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:-98
> -	   this.addRepresentedObjectToNewChildQueue(event.data.item);

I'm not familiar with the function, what was the intent behind
this.addRepresentedObjectToNewChildQueue?


More information about the webkit-reviews mailing list