[webkit-reviews] review granted: [Bug 178969] Correctly determine affinity when inserting text via Keyboard Suggestions : [Attachment 325231] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 30 12:11:11 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 178969: Correctly determine affinity when inserting text via Keyboard
Suggestions
https://bugs.webkit.org/show_bug.cgi?id=178969

Attachment 325231: Patch

https://bugs.webkit.org/attachment.cgi?id=325231&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 325231
  --> https://bugs.webkit.org/attachment.cgi?id=325231
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325231&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1865
> +    // correctly determine affinity, using logic currently only present in
VisiblePosition

Nit: Capitalize "correctly".


More information about the webkit-reviews mailing list