[webkit-reviews] review granted: [Bug 178980] Web Inspector: replace Canvas stack iteration with createScriptCallStack : [Attachment 325278] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 30 11:53:59 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178980: Web Inspector: replace Canvas stack iteration with
createScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=178980

Attachment 325278: Patch

https://bugs.webkit.org/attachment.cgi?id=325278&action=review




--- Comment #23 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 325278
  --> https://bugs.webkit.org/attachment.cgi?id=325278
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325278&action=review

r=me

> Source/WebCore/inspector/InspectorCanvas.cpp:262
> +	   auto stackTrace =
Inspector::createScriptCallStack(JSMainThreadExecState::currentState(),
Inspector::ScriptCallStack::maxCallStackSizeToCapture);

We should really make ScriptCallStack::maxCallStackSizeToCapture a default
value. Its ridiculous that pretty much every caller passes it.

> LayoutTests/inspector/canvas/create-context-2d-expected.txt:33
> +  0: getCSSCanvasContext - [native code]

Nice! See it is worth including the native function!


More information about the webkit-reviews mailing list