[webkit-reviews] review granted: [Bug 176198] tab-size: 0px asserts : [Attachment 325360] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 30 11:20:33 PDT 2017


Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 176198: tab-size: 0px asserts
https://bugs.webkit.org/show_bug.cgi?id=176198

Attachment 325360: Patch

https://bugs.webkit.org/attachment.cgi?id=325360&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 325360
  --> https://bugs.webkit.org/attachment.cgi?id=325360
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325360&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1116
> +static RefPtr<CSSValue> consumeTabSize(CSSParserTokenRange& range,
CSSParserMode)
>  {
> -    RefPtr<CSSPrimitiveValue> parsedValue = consumeInteger(range, 0);
> -    if (parsedValue)
> -	   return parsedValue;
> -    return consumeLength(range, cssParserMode, ValueRangeNonNegative);
> +    return consumeInteger(range, 0);

You could add a FIXME mentioning we lack support for length values.


More information about the webkit-reviews mailing list