[webkit-reviews] review granted: [Bug 176719] WKBundlePageWillSendSubmitEventCallback is called with incorrect frame parameter : [Attachment 324891] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 30 09:45:20 PDT 2017


Chris Dumez <cdumez at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 176719: WKBundlePageWillSendSubmitEventCallback is called with incorrect
frame parameter
https://bugs.webkit.org/show_bug.cgi?id=176719

Attachment 324891: Patch

https://bugs.webkit.org/attachment.cgi?id=324891&action=review




--- Comment #26 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 324891
  --> https://bugs.webkit.org/attachment.cgi?id=324891
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324891&action=review

r=me

> Source/WebCore/html/HTMLFormElement.cpp:671
> +	   for (auto node = event->target()->toNode(); node; node =
node->parentNode()) {

assuming toNode() returns a raw pointer, I'd prefer auto* than auto. But
really, I think this should use:
auto* targetNode = event->target()->toNode();
return targetNode ? lineageOfType<HTMLFormControlElement>(*targetNode)).first()
: nullptr;


More information about the webkit-reviews mailing list