[webkit-reviews] review requested: [Bug 178328] Web Inspector: [PARITY] Styles Redesign: Ability to modify style attributes : [Attachment 325217] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 29 13:47:22 PDT 2017


Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 178328: Web Inspector: [PARITY] Styles Redesign: Ability to modify style
attributes
https://bugs.webkit.org/show_bug.cgi?id=178328

Attachment 325217: Patch

https://bugs.webkit.org/attachment.cgi?id=325217&action=review




--- Comment #9 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 325217
  --> https://bugs.webkit.org/attachment.cgi?id=325217
Patch

(In reply to Matt Baker from comment #8)
> Comment on attachment 325217 [details]
> Patch
> 
> r-, for the following issue:
> 
> Editing the style attribute via the sidebar causes a space to be prepended
> to the style attribute text in the DOM tree:
> 
> 1. Open the test page
> (http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/style-
> attributes.html)
> 2. In the sidebar, change "darkslateblue" to "red"
>   => Style attribute changes to " color: red"

This works the same in the old styles sidebar.

I filed Bug 178990 - Web Inspector: Styles: Editing style attribute prepends
line-break.

I'm setting my patch back to "r?".


More information about the webkit-reviews mailing list