[webkit-reviews] review denied: [Bug 174229] Web Inspector: Styles: make "Computed" a top-level tab : [Attachment 325275] WIP
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 28 19:56:12 PDT 2017
Nikita Vasilyev <nvasilyev at apple.com> has denied review:
Bug 174229: Web Inspector: Styles: make "Computed" a top-level tab
https://bugs.webkit.org/show_bug.cgi?id=174229
Attachment 325275: WIP
https://bugs.webkit.org/attachment.cgi?id=325275&action=review
--- Comment #2 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 325275
--> https://bugs.webkit.org/attachment.cgi?id=325275&action=review
WIP
Not ready for review yet, but you can apply the patch and try the new tabs.
Known issues:
— Command-clicking on a property in Computed to jump to a corresponding
property in Styles is now broken.
— Ideally, the filter field should be shared between Styles and Computed, e.g.
switching between Styles and Computed should preserve the filter field value.
This isn't the case in Chrome. Also, I haven't yet implemented filtering in the
redesigned styles panel.
The newly added StyleRulesDetailsSidebarPanel.js and
StyleComputedDetailsSidebarPanel.js are trimmed down versions of
CSSStyleDetailsSidebarPanel.js. I'm still thinking what's the best way to
reduce code duplication between the two.
More information about the webkit-reviews
mailing list