[webkit-reviews] review granted: [Bug 178976] self.ExtendableEvent / Client / Clients / WindowClient do not exist in a Service Worker : [Attachment 325239] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 28 07:08:37 PDT 2017


Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178976: self.ExtendableEvent / Client / Clients / WindowClient do not exist
in a Service Worker
https://bugs.webkit.org/show_bug.cgi?id=178976

Attachment 325239: Patch

https://bugs.webkit.org/attachment.cgi?id=325239&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 325239
  --> https://bugs.webkit.org/attachment.cgi?id=325239
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325239&action=review

>>
LayoutTests/http/tests/workers/service/resources/ServiceWorkerGlobalScope-prope
rties-worker.js:9
>> +self.addEventListener("message", (event) => {
>> +	if (event.data === "LIST") {
>> +	    let properties = Object.getOwnPropertyNames(self);
>> +	    properties.sort()
>> +	    for (let p of properties)
>> +		event.source.postMessage(p);
>> +	    event.source.postMessage("DONE");
>> +	}
>> +});
> 
> I'm not a big fan of this type of test, as it tends to be hard to keep one
set of expected results as some platforms enable some features (I recently
removed a similar set of tests for windows).  Can we have a more targeted test,
rather than one that iterates all of the global object?

I'm not a big fan of this type of test, as it tends to be hard to keep one set
of expected results as some platforms enable some features (I recently removed
a similar set of tests for windows).  Can we have a more targeted test, rather
than one that iterates all of the global object?


More information about the webkit-reviews mailing list