[webkit-reviews] review granted: [Bug 178965] Create watchlist for files related WebInspector Recording : [Attachment 325223] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 27 17:29:13 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178965: Create watchlist for files related WebInspector Recording
https://bugs.webkit.org/show_bug.cgi?id=178965

Attachment 325223: Patch

https://bugs.webkit.org/attachment.cgi?id=325223&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 325223
  --> https://bugs.webkit.org/attachment.cgi?id=325223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325223&action=review

r=me

> Tools/Scripts/webkitpy/common/config/watchlist:195
> +			   r"|Source/WebCore/bindings/js/CallTracer.*"
> +			   r"|Source/WebCore/inspector/Recording.*"
> +			  
r"|Source/WebInspectorUI/UserInterface/\w*/Recording.*.js"
> +			   # Canvas
> +			   r"|Source/WebCore/inspector/InspectorCanvas.*"
> +			   r"|Source/WebCore/html/canvas/Canvas.*.idl"
> +			  
r"|Source/WebCore/html/canvas/WebGLRenderingContext.idl"
> +			  
r"|Source/WebCore/html/canvas/WebGLRenderingContextBase.idl"

Nit: I believe we normally put a trailing comma after the last value.
Nit: For all the dots that are literal dots (like right before the file
extension) you should escape. For example `\.idl` and `\.js`.
Nit: I think all of these ending in ".*" are unnecessary, but I do see some
existing examples so feel free to keep.


More information about the webkit-reviews mailing list