[webkit-reviews] review denied: [Bug 178967] Make WKWebViewConfiguration a wrapper around API::PageConfiguration : [Attachment 325220] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 27 16:57:37 PDT 2017


Alex Christensen <achristensen at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 178967: Make WKWebViewConfiguration a wrapper around API::PageConfiguration
https://bugs.webkit.org/show_bug.cgi?id=178967

Attachment 325220: Patch

https://bugs.webkit.org/attachment.cgi?id=325220&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 325220
  --> https://bugs.webkit.org/attachment.cgi?id=325220
Patch

There are a few things wrong with this patch, but it's good WIP.
Among the problems are: this assertion is firing and I'm not sure why:
    ASSERT([pageConfiguration.wrapper() isKindOfClass:[WKWebViewConfiguration
class]]);


More information about the webkit-reviews mailing list