[webkit-reviews] review granted: [Bug 178924] Implement WKFullscreenWindowController for iOS. : [Attachment 325191] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 27 14:41:46 PDT 2017
Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 178924: Implement WKFullscreenWindowController for iOS.
https://bugs.webkit.org/show_bug.cgi?id=178924
Attachment 325191: Patch
https://bugs.webkit.org/attachment.cgi?id=325191&action=review
--- Comment #13 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 325191
--> https://bugs.webkit.org/attachment.cgi?id=325191
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=325191&action=review
r=me, with nit. One question: does this change mean that <video>'s
webkitEnterFullScreen() will now use element fullscreen?
> Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.mm:358
> +#if BOXES
> + UIView *inlineRepView = nil;
> + UIView *fullscreenRepView = nil;
> + {
> + inlineRepView = [[UIView alloc] initWithFrame:inlineFrame];
> + inlineRepView.layer.borderColor = UIColor.greenColor.CGColor;
> + inlineRepView.layer.borderWidth = 6.0;
> + [containerView addSubview:inlineRepView];
> +
> + fullscreenRepView = [[UIView alloc] initWithFrame:fullscreenFrame];
> + fullscreenRepView.layer.borderColor = UIColor.redColor.CGColor;
> + fullscreenRepView.layer.borderWidth = 6.0;
> + [containerView addSubview:fullscreenRepView];
> + }
> +#endif
Can these be safely removed? I see that BOXES is defined as 0.
> Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.mm:365
> + } completion:^(BOOL finished){
> + BOOL success = ![transitionContext transitionWasCancelled];
Interesting that finished != success.
More information about the webkit-reviews
mailing list