[webkit-reviews] review granted: [Bug 178934] [DFG][FTL] Introduce StringSlice : [Attachment 325150] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 27 10:12:30 PDT 2017
Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 178934: [DFG][FTL] Introduce StringSlice
https://bugs.webkit.org/show_bug.cgi?id=178934
Attachment 325150: Patch
https://bugs.webkit.org/attachment.cgi?id=325150&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 325150
--> https://bugs.webkit.org/attachment.cgi?id=325150
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=325150&action=review
> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2919
> + if (argumentCountIncludingThis != 2)
Nit: even though they’re equivalent in this context, I think > 2 is more
intuitive
> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4309
> + // end would be nullptr.
would => can
> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4320
> + LValue startIndex = m_out.select(m_out.greaterThanOrEqual(start,
m_out.int32Zero),
These two boundary selections are equivalent if parameterized on start/end.
Might be worth making a lambda
More information about the webkit-reviews
mailing list