[webkit-reviews] review granted: [Bug 178928] [Web Animations] Expose the currentTime property on AnimationTimeline : [Attachment 325141] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 27 03:32:43 PDT 2017


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 178928: [Web Animations] Expose the currentTime property on
AnimationTimeline
https://bugs.webkit.org/show_bug.cgi?id=178928

Attachment 325141: Patch

https://bugs.webkit.org/attachment.cgi?id=325141&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 325141
  --> https://bugs.webkit.org/attachment.cgi?id=325141
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325141&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:57
> +    if (m_currentTime)

Flip this logic around. Put the nullopt case in the if.

> LayoutTests/webanimations/timeline-current-time.html:11
> +internals.setTimelineCurrentTime(document.timeline, 1);

Should also test null and negative values.


More information about the webkit-reviews mailing list