[webkit-reviews] review granted: [Bug 178160] [GStreamer][MSE] Trim space between codecs : [Attachment 325016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 27 02:16:06 PDT 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 178160: [GStreamer][MSE] Trim space between codecs
https://bugs.webkit.org/show_bug.cgi?id=178160

Attachment 325016: Patch

https://bugs.webkit.org/attachment.cgi?id=325016&action=review




--- Comment #25 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 325016
  --> https://bugs.webkit.org/attachment.cgi?id=325016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325016&action=review

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:845
> +	   codec = codec.substring(slashIndex+1);

slashIndex + 1

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:850
> +	   bool codecMatchesPattern = !fnmatch(pattern.string().utf8().data(),
codec.utf8().data(), 0);
> +	   if (codecMatchesPattern)
> +	       return true;

You don't need the variable, just if to the fnmatch and return true.

Btw, the name of the variable should be doesCodecMatchPattern according to
https://webkit.org/code-style-guidelines/#names


More information about the webkit-reviews mailing list