[webkit-reviews] review requested: [Bug 176894] [WinCairo] Add WTF files for wincairo webkit : [Attachment 325106] [PATCH] Add WTF files for WinCairo WebKit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 26 20:03:45 PDT 2017
Yousuke Kimoto <Yousuke.Kimoto at sony.com> has asked for review:
Bug 176894: [WinCairo] Add WTF files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=176894
Attachment 325106: [PATCH] Add WTF files for WinCairo WebKit
https://bugs.webkit.org/attachment.cgi?id=325106&action=review
--- Comment #19 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
Created attachment 325106
--> https://bugs.webkit.org/attachment.cgi?id=325106&action=review
[PATCH] Add WTF files for WinCairo WebKit
(In reply to Alex Christensen from comment #18)
> Comment on attachment 325022 [details]
> [PATCH] Add WTF files for WinCairo WebKit
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325022&action=review
>
> > Source/WTF/wtf/win/WorkItemContext.h:49
> > + HANDLE* waitHandlePtr() { return &m_waitHandle.m_handle; }
>
> This is unnecessary.
I deleted this line and used a direct reference to the address.
> > Source/WTF/wtf/win/WorkItemContext.h:56
> > + Win32Handle m_handle = { };
>
> These default constructors are unnecessary. If we needed them, the = would
> be unnecessary.
>
> > Source/WTF/wtf/win/WorkQueueWin.cpp:57
> > + {
>
> This scope is unnecessary.
Those unnecessary lines were deleted.
More information about the webkit-reviews
mailing list