[webkit-reviews] review granted: [Bug 178902] Windows and WebViews are retained after re-configure : [Attachment 325083] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 17:48:57 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 178902: Windows and WebViews are retained after re-configure
https://bugs.webkit.org/show_bug.cgi?id=178902

Attachment 325083: Patch

https://bugs.webkit.org/attachment.cgi?id=325083&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 325083
  --> https://bugs.webkit.org/attachment.cgi?id=325083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325083&action=review

> Tools/WebKitTestRunner/TestController.cpp:1180
> +    WTF::AutodrainedPool pool;

Please remove "WTF::", AutodrainedPool is exported to the global scope (as
should all public WTF symbols).


More information about the webkit-reviews mailing list