[webkit-reviews] review granted: [Bug 178840] Move WKWebViewConfiguration validation to WKWebView construction : [Attachment 325041] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 16:38:46 PDT 2017


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 178840: Move WKWebViewConfiguration validation to WKWebView construction
https://bugs.webkit.org/show_bug.cgi?id=178840

Attachment 325041: Patch

https://bugs.webkit.org/attachment.cgi?id=325041&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 325041
  --> https://bugs.webkit.org/attachment.cgi?id=325041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325041&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:450
> +- (void)_validateConfiguration:(WKWebViewConfiguration *)configuration

maybe this can just be a free function?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:52
> +	   [configuration setProcessPool: nil];

No spaces after colons!


More information about the webkit-reviews mailing list