[webkit-reviews] review granted: [Bug 178806] Web Inspector: Canvas Tab: canvas path components from old page stick around when page is reloaded : [Attachment 324912] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 16:34:10 PDT 2017


Brian Burg <bburg at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178806: Web Inspector: Canvas Tab: canvas path components from old page
stick around when page is reloaded
https://bugs.webkit.org/show_bug.cgi?id=178806

Attachment 324912: Patch

https://bugs.webkit.org/attachment.cgi?id=324912&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324912
  --> https://bugs.webkit.org/attachment.cgi?id=324912
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324912&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +

You never really explained why the code was wrong or what the fix does
differently.

> Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:185
> +	   for (let recording of canvas.recordingCollection.items) {

I would comment here that we are converting the gone canvas' recordings to be
imported recordings.


More information about the webkit-reviews mailing list