[webkit-reviews] review granted: [Bug 178089] Call setFullscreenClient on iOS. : [Attachment 324874] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 178089: Call setFullscreenClient on iOS.
https://bugs.webkit.org/show_bug.cgi?id=178089

Attachment 324874: Patch

https://bugs.webkit.org/attachment.cgi?id=324874&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324874
  --> https://bugs.webkit.org/attachment.cgi?id=324874
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324874&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:205
> +   
_page->setFullscreenClient(std::make_unique<WebKit::FullscreenClient>(_webView)
);

This API seems a bit weird. Normally you don't pass ownership of a client to
the thing that it's a client of. You hold ownership, and the client
relationship is weak.