[webkit-reviews] review granted: [Bug 178876] Bring back SWContextManager abstraction in WebCore : [Attachment 325040] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 12:54:19 PDT 2017


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178876: Bring back SWContextManager abstraction in WebCore
https://bugs.webkit.org/show_bug.cgi?id=178876

Attachment 325040: Patch

https://bugs.webkit.org/attachment.cgi?id=325040&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 325040
  --> https://bugs.webkit.org/attachment.cgi?id=325040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325040&action=review

r=me

> Source/WebCore/workers/service/context/SWContextManager.cpp:68
> +    // FIXME: We should pass valid MessagePortChannels.

Can you add a bug for this?

> Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:99
> +    // FIXME: Provide a sensical session ID.

And this?


More information about the webkit-reviews mailing list