[webkit-reviews] review granted: [Bug 176894] [WinCairo] Add WTF files for wincairo webkit : [Attachment 325022] [PATCH] Add WTF files for WinCairo WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 12:06:03 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Yousuke Kimoto
<Yousuke.Kimoto at sony.com>'s request for review:
Bug 176894: [WinCairo] Add WTF files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=176894

Attachment 325022: [PATCH] Add WTF files for WinCairo WebKit

https://bugs.webkit.org/attachment.cgi?id=325022&action=review




--- Comment #18 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 325022
  --> https://bugs.webkit.org/attachment.cgi?id=325022
[PATCH] Add WTF files for WinCairo WebKit

View in context: https://bugs.webkit.org/attachment.cgi?id=325022&action=review

> Source/WTF/wtf/win/WorkItemContext.h:49
> +    HANDLE* waitHandlePtr() { return &m_waitHandle.m_handle; }

This is unnecessary.

> Source/WTF/wtf/win/WorkItemContext.h:56
> +    Win32Handle m_handle = { };

These default constructors are unnecessary.  If we needed them, the = would be
unnecessary.

> Source/WTF/wtf/win/WorkQueueWin.cpp:57
> +    {

This scope is unnecessary.


More information about the webkit-reviews mailing list