[webkit-reviews] review granted: [Bug 178878] [WPE] Use proper shared object versioning for libWPEWebKit.so : [Attachment 325032] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 11:25:28 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 178878: [WPE] Use proper shared object versioning for libWPEWebKit.so
https://bugs.webkit.org/show_bug.cgi?id=178878

Attachment 325032: Patch

https://bugs.webkit.org/attachment.cgi?id=325032&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 325032
  --> https://bugs.webkit.org/attachment.cgi?id=325032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325032&action=review

> Source/cmake/OptionsWPE.cmake:4
> +SET_PROJECT_VERSION(2 19 0)

Please use 0 19 0 for WPE, like we discussed internally today. We can always
raise the first version later, and I absolutely plan to do that, but for now
keeping a leading 0 would be nice to indicate it's still unstable.

Alternatively, if you prefer, you could add an optional nano version (that
would not be used for WebKitGTK+) and make it 0 2 19 0. Maybe that would be the
least-confusing option.


More information about the webkit-reviews mailing list