[webkit-reviews] review requested: [Bug 176894] [WinCairo] Add WTF files for wincairo webkit : [Attachment 325022] [PATCH] Add WTF files for WinCairo WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 10:03:12 PDT 2017


Yousuke Kimoto <Yousuke.Kimoto at sony.com> has asked  for review:
Bug 176894: [WinCairo] Add WTF files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=176894

Attachment 325022: [PATCH] Add WTF files for WinCairo WebKit

https://bugs.webkit.org/attachment.cgi?id=325022&action=review




--- Comment #17 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
Created attachment 325022

  --> https://bugs.webkit.org/attachment.cgi?id=325022&action=review

[PATCH] Add WTF files for WinCairo WebKit

(In reply to Alex Christensen from comment #16)
> Comment on attachment 324021 [details]
> [PATCH] Add WTF files for WinCairo WebKit
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324021&action=review
> 
> > Source/WTF/wtf/win/WorkItemContext.cpp:42
> > +	 // how to delete handles??
> 
> Yeah, let's not land code with a comment like this.
The unnecessary comment was deleted and Win32Handle is used to manage windows
handles in this patch.


More information about the webkit-reviews mailing list