[webkit-reviews] review granted: [Bug 178846] Add inspector logging for MediaElementSession autoplay : [Attachment 324953] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 26 05:21:53 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 178846: Add inspector logging for MediaElementSession autoplay
https://bugs.webkit.org/show_bug.cgi?id=178846
Attachment 324953: Patch
https://bugs.webkit.org/attachment.cgi?id=324953&action=review
--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 324953
--> https://bugs.webkit.org/attachment.cgi?id=324953
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324953&action=review
> Source/WebCore/html/MediaElementSession.cpp:112
> + , m_logIdentifier(reinterpret_cast<const
void*>(cryptographicallyRandomNumber()))
I think it would be better to use the media element’s identifier, so it will be
easier to understand logging for pages with more than one element.
> Source/WebCore/html/MediaElementSession.cpp:846
> +bool MediaElementSession::willLog(WTFLogLevel level) const
Is it possible to just use the media element method?
> Source/WebCore/html/MediaElementSession.cpp:857
> +WTFLogChannel& MediaElementSession::logChannel() const
Ditto.
More information about the webkit-reviews
mailing list