[webkit-reviews] review granted: [Bug 178843] Remove code to update block selection : [Attachment 324949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 20:39:20 PDT 2017


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 178843: Remove code to update block selection
https://bugs.webkit.org/show_bug.cgi?id=178843

Attachment 324949: Patch

https://bugs.webkit.org/attachment.cgi?id=324949&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 324949
  --> https://bugs.webkit.org/attachment.cgi?id=324949
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324949&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3960
> +    if ((!_selectionNeedsUpdate) ||
(_page->editorState().isMissingPostLayoutData))

Too many parens. Also, this should be in its own patch! Possibly with a test :)

r=me for the rest.


More information about the webkit-reviews mailing list