[webkit-reviews] review granted: [Bug 178842] Fix issues with WebView subframe painting : [Attachment 324940] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 178842: Fix issues with WebView subframe painting
https://bugs.webkit.org/show_bug.cgi?id=178842

Attachment 324940: Patch

https://bugs.webkit.org/attachment.cgi?id=324940&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 324940
  --> https://bugs.webkit.org/attachment.cgi?id=324940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324940&action=review

> Source/WebKitLegacy/mac/ChangeLog:11
> +	   WebHTMLView overrides some NSView internal methods to make sure that
AppKit doesn't paint
> +	   subframes (WebKit controls subframe painting). The method signature
of one of these changed in macOS
> +	   High Sierra, so match the new signature.

Is there an equivalent to C++11's override keyword to help us catch such
changes in the future and/or can we write a unit test to ensure this does not
regress?