[webkit-reviews] review granted: [Bug 178838] Implement seek tolerance methods in WebAVPlayerController. : [Attachment 324925] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 25 17:18:50 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 178838: Implement seek tolerance methods in WebAVPlayerController.
https://bugs.webkit.org/show_bug.cgi?id=178838
Attachment 324925: Patch
https://bugs.webkit.org/attachment.cgi?id=324925&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 324925
--> https://bugs.webkit.org/attachment.cgi?id=324925
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324925&action=review
> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:143
> + void seekToTime(double, double, double) override;
Nit : some of the changes in this patch won’t be necessary if you give the new
parameters default values of 0.
More information about the webkit-reviews
mailing list