[webkit-reviews] review granted: [Bug 160234] Check if NSURLAuthenticationChallengeSender has implemented optional methods before calling them : [Attachment 324849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 15:57:13 PDT 2017


Geoffrey Garen <ggaren at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 160234: Check if NSURLAuthenticationChallengeSender has implemented
optional methods before calling them
https://bugs.webkit.org/show_bug.cgi?id=160234

Attachment 324849: Patch

https://bugs.webkit.org/attachment.cgi?id=324849&action=review




--- Comment #43 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 324849
  --> https://bugs.webkit.org/attachment.cgi?id=324849
Patch

r=me

I think this is an improvement because it clarifies that NETWORK_SESSION code
is never supposed to invoke the deprecated default... selector, and it removes
the crash from customer builds.

To continue investigating the mystery of why we end up with an authentication
challenge that has no client or completion handler, I'd suggest adding code
like this to NetworkDataTaskCocoa::didReceiveChallenge:

	if (internal_build())
	    RELEASE_ASSERT_NOT_REACHED();
	else
	    ASSERT_NOT_REACHED();

If we discover that we use this kind of technique more often, consider making a
shared macro in Assertions.h that encapsulates this behavior.


More information about the webkit-reviews mailing list