[webkit-reviews] review granted: [Bug 178803] Web Inspector: Canvas Tab: clicking on a canvas card causes details sidebar to show and mess up card arrangement : [Attachment 324886] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 14:53:34 PDT 2017


Brian Burg <bburg at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178803: Web Inspector: Canvas Tab: clicking on a canvas card causes details
sidebar to show and mess up card arrangement
https://bugs.webkit.org/show_bug.cgi?id=178803

Attachment 324886: Patch

https://bugs.webkit.org/attachment.cgi?id=324886&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324886
  --> https://bugs.webkit.org/attachment.cgi?id=324886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324886&action=review

r=me

> Source/WebInspectorUI/ChangeLog:25
> +	   Drive-by: these sidebar panels are now only used by the Canvas tab,
so we no longer need to

Nice.

> Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.css:45
> +    padding: 5px 15px 6px;

This ain't gonna work with RTL layout. Can you split out padding and make it
flip correctly?

> Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js:-103
> -	   this.contentView.element.appendChild(identitySection.element);

Nice cleanup.

> Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js:150
> +	   this.contentView.element.append(...this._sections.map(section =>
section.element));

Slick.


More information about the webkit-reviews mailing list