[webkit-reviews] review denied: [Bug 178824] Add downcast support for FullscreenClient. : [Attachment 324878] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 14:16:30 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 178824: Add downcast support for FullscreenClient.
https://bugs.webkit.org/show_bug.cgi?id=178824

Attachment 324878: Patch

https://bugs.webkit.org/attachment.cgi?id=324878&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324878
  --> https://bugs.webkit.org/attachment.cgi?id=324878
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324878&action=review

> Source/WebKit/UIProcess/Cocoa/FullscreenClient.h:44
> +    static int type;
> +    bool isType(void* target) const override { return target == &type ||
API::FullscreenClient::isType(target);};

This is really weird. Why the generic types (int and void*) and not enums and
classes?


More information about the webkit-reviews mailing list