[webkit-reviews] review granted: [Bug 178715] Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource : [Attachment 324877] Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 14:13:09 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 178715: Style::Scope::flushPendingUpdate() can replace the entire document
in XSLTProcessor::createDocumentFromSource
https://bugs.webkit.org/show_bug.cgi?id=178715

Attachment 324877: Cleanup

https://bugs.webkit.org/attachment.cgi?id=324877&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 324877
  --> https://bugs.webkit.org/attachment.cgi?id=324877
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=324877&action=review

Looks good! r=me.

> Source/WebCore/dom/Document.cpp:5082
> +	   RefPtr<XSLTProcessor> processor = XSLTProcessor::create();

auto?

> Source/WebCore/style/StyleScope.cpp:294
> +// FIXME: Remove the code related to XSLT from Style::Scope.

Can you file a bug (or Radar) so we don't forget to do this?


More information about the webkit-reviews mailing list