[webkit-reviews] review granted: [Bug 178816] Make toJS() do the right thing for ServiceWorkerClient : [Attachment 324867] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 14:02:19 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178816: Make toJS() do the right thing for ServiceWorkerClient
https://bugs.webkit.org/show_bug.cgi?id=178816

Attachment 324867: Patch

https://bugs.webkit.org/attachment.cgi?id=324867&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 324867
  --> https://bugs.webkit.org/attachment.cgi?id=324867
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324867&action=review

> Source/WebCore/ChangeLog:8
> +	   Make toJS() to the right thing for ServiceWorkerClient. In
particular,

s/to/do/

> Source/WebCore/bindings/js/JSServiceWorkerClientCustom.cpp:33
> +#include "ServiceWorkerWindowClient.h"

These two "Service.." are probably not needed.
JSServiceWorkerWindowClient.h is also probably including
JSServiceWorkerClient.h.


More information about the webkit-reviews mailing list