[webkit-reviews] review granted: [Bug 178805] Web Inspector: Canvas Tab: starting a second recording doesn't show red titlebar if the first recording was empty : [Attachment 324865] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 25 13:24:13 PDT 2017
Brian Burg <bburg at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178805: Web Inspector: Canvas Tab: starting a second recording doesn't show
red titlebar if the first recording was empty
https://bugs.webkit.org/show_bug.cgi?id=178805
Attachment 324865: Patch
https://bugs.webkit.org/attachment.cgi?id=324865&action=review
--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324865
--> https://bugs.webkit.org/attachment.cgi?id=324865
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324865&action=review
r=me with some test issues. Please re-EWS the test changes, thanks.
> LayoutTests/inspector/canvas/recording-2d.html:480
> + throw "Missing 2D canvas.";
Does an async function wrap this in an Error? If not, please throw an Error.
Throwing a string will lose exception context, IIRC.
> LayoutTests/inspector/canvas/recording-2d.html:493
> + await CanvasAgent.stopRecording(canvas.identifier);
It is weird to use CanvasAgent directly, but use CanvasManager right above. I'd
prefer you stick to manager API if using inspector-test.js
More information about the webkit-reviews
mailing list