[webkit-reviews] review granted: [Bug 178774] UNPACK_FLIP_Y is broken for MSE-backed videos : [Attachment 324824] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 12:05:17 PDT 2017


Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 178774: UNPACK_FLIP_Y is broken for MSE-backed videos
https://bugs.webkit.org/show_bug.cgi?id=178774

Attachment 324824: Patch

https://bugs.webkit.org/attachment.cgi?id=324824&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 324824
  --> https://bugs.webkit.org/attachment.cgi?id=324824
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324824&action=review

> Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:401
> -	   "	   gl_Position.y = -gl_Position.y;\n"
> +	   "	   normalizedPosition.y = 1.0 - normalizedPosition.y;\n"

Haha. My fault for not noticing this when reviewing.


More information about the webkit-reviews mailing list