[webkit-reviews] review granted: [Bug 178045] Web Inspector: replace TypeVerifier with subclasses of WI.Collection : [Attachment 324858] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 25 11:54:39 PDT 2017
Brian Burg <bburg at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178045: Web Inspector: replace TypeVerifier with subclasses of
WI.Collection
https://bugs.webkit.org/show_bug.cgi?id=178045
Attachment 324858: Patch
https://bugs.webkit.org/attachment.cgi?id=324858&action=review
--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324858
--> https://bugs.webkit.org/attachment.cgi?id=324858
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324858&action=review
r=me please wait for Mac EWS
> Source/WebInspectorUI/UserInterface/Models/Collection.js:70
> + return true;
If this is required to be overridden, then please
throw WI.NotImplementedError.subclassMustOverride();
> Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js:57
> return WI.UIString("Shader Programs");
I wouldn't be sad if you made this a displayName() that must be overridden, but
I won't hold up this patch for it either.
;-)
More information about the webkit-reviews
mailing list