[webkit-reviews] review granted: [Bug 178812] [Service Worker] Add stubs for serviceWorkerClient.type : [Attachment 324855] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 11:45:40 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178812: [Service Worker] Add stubs for serviceWorkerClient.type
https://bugs.webkit.org/show_bug.cgi?id=178812

Attachment 324855: Patch

https://bugs.webkit.org/attachment.cgi?id=324855&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 324855
  --> https://bugs.webkit.org/attachment.cgi?id=324855
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324855&action=review

> Source/WebCore/ChangeLog:9
> +	   - ttps://w3c.github.io/ServiceWorker/#enumdef-clienttype

s//ttps/https

> Source/WebCore/ChangeLog:19
> +	   * workers/service/ServiceWorkerClientType.h: Copied from
Source/WebCore/workers/service/ServiceWorkerClient.idl.

Added

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:2924
> +		8369FDFC1FA102E300C1FF1F /* ServiceWorkerClientType.h in
Headers */ = {isa = PBXBuildFile; fileRef = 8369FDFB1FA102CB00C1FF1F /*
ServiceWorkerClientType.h */; };

Shouldn't there also be some JSServiceWorkerClientType. files added?


More information about the webkit-reviews mailing list